Skip to content

Conversation

@Riandy
Copy link
Contributor

@Riandy Riandy commented Sep 26, 2024

Summary:

  • rename XNNPACK
  • remove duplicate executorch setup instructions
  • remove tokenizer conversion step (since iOS supports both .bin and .model)
  • move model copying section to after xcode setup

Differential Revision: D63479985

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5695

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 1ac5809 with merge base 9d224a5 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63479985

Summary:
Pull Request resolved: pytorch#5695

- rename XNNPACK
- remove duplicate executorch setup instructions
- remove tokenizer conversion step (since iOS supports both .bin and .model)
- move model copying section to after xcode setup

Reviewed By: cmodi-meta, kirklandsign

Differential Revision: D63479985
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63479985

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7e9eaa8.

@Riandy
Copy link
Contributor Author

Riandy commented Sep 26, 2024

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Sep 26, 2024
Summary:
Pull Request resolved: #5695

- rename XNNPACK
- remove duplicate executorch setup instructions
- remove tokenizer conversion step (since iOS supports both .bin and .model)
- move model copying section to after xcode setup

Reviewed By: cmodi-meta, kirklandsign

Differential Revision: D63479985

fbshipit-source-id: bd1030588fa997f26c0c8da59f5850b06141aa43
(cherry picked from commit 7e9eaa8)
@pytorchbot
Copy link
Collaborator

Cherry picking #5695

The cherry pick PR is at #5713 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Riandy added a commit that referenced this pull request Sep 27, 2024
Readme docs update (#5695)

Summary:
Pull Request resolved: #5695

- rename XNNPACK
- remove duplicate executorch setup instructions
- remove tokenizer conversion step (since iOS supports both .bin and .model)
- move model copying section to after xcode setup

Reviewed By: cmodi-meta, kirklandsign

Differential Revision: D63479985

fbshipit-source-id: bd1030588fa997f26c0c8da59f5850b06141aa43
(cherry picked from commit 7e9eaa8)

Co-authored-by: Riandy Riandy <riandymdn@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants