[ExecuTorch] Fix non-reentrant threadpool #5714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we tried to reenter parallel_for, we would deadlock due to trying to acquire the threadpool mutex, which was already held. Removing the mutex (which is unnecessary) didn't fix the problem because pthreadpool has its own internal mutex. Differential Revision: [D62052200](https://our.internmc.facebook.com/intern/diff/D62052200/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5714
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 75b9f1d with merge base 1cf3da3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62052200 |
swolchok
added a commit
that referenced
this pull request
Sep 26, 2024
If we tried to reenter parallel_for, we would deadlock due to trying to acquire the threadpool mutex, which was already held. Removing the mutex (which is unnecessary) didn't fix the problem because pthreadpool has its own internal mutex. Differential Revision: [D62052200](https://our.internmc.facebook.com/intern/diff/D62052200/) ghstack-source-id: 244975544 Pull Request resolved: #5714
kimishpatel
approved these changes
Sep 27, 2024
Contributor
|
This pull request has been merged in a5c9dee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
If we tried to reenter parallel_for, we would deadlock due to trying to acquire the threadpool mutex, which was already held. Removing the mutex (which is unnecessary) didn't fix the problem because pthreadpool has its own internal mutex.
Differential Revision: D62052200