Use aliasing constructor instead of a custom deleter in TensorImplPtr. #5741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#5725) Summary: Pull Request resolved: #5725 `shared_ptr` has a so-called aliasing constructor, that allows it to manage one object, but effectively point to another one. Here we use it to keep the data/metadata bundled together, but make the `shared_ptr` expose the address of the `TensorImpl` instance only. Reviewed By: dbort Differential Revision: D63545997 fbshipit-source-id: 374d8a0ed1a1558608d59246b4c6c44cb0c13398 (cherry picked from commit c3460e5)
This was referenced Sep 28, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5741
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f47569b with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
Let's leave this for the next release unless it fixes a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: .
Differential Revision: D63545997