Add model files support for android tokenizer #5768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: #5727 Add model files support for android tokenizer. Previously we only support .bin files, but since the runner also supports .model now, updating the app side logic to allow .model tokenizer files. Reviewed By: larryliu0820 Differential Revision: D63491811 fbshipit-source-id: b01ca836798794cbd0b0b377aa096a5c61a8f715 (cherry picked from commit fcdfe06)
This was referenced Sep 30, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5768
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e0f580a with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add model files support for android tokenizer. Previously we only support .bin files, but since the runner also supports .model now, updating the app side logic to allow .model tokenizer files.
Differential Revision: D63491811