Skip to content

Conversation

@Olivia-liu
Copy link
Contributor

Differential Revision: D63738952

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5809

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 04afdf1 with merge base 5acd5c9 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63738952

Olivia-liu and others added 2 commits October 2, 2024 15:59
Differential Revision: D63738950
Summary:
Pull Request resolved: #5809

This diff is to rename the "sdk-etdump" documentation page to just "etdump".

Old URL: https://pytorch.org/executorch/main/sdk-etdump.html
New URL ("sdk" is removed):
https://pytorch.org/executorch/main/etdump.html

Design doc: https://docs.google.com/document/d/1l6DYTq9Kq6VrPohruRFP-qScZDj01W_g4zlKyvqKGF4/edit?usp=sharing

Reviewed By: dbort

Differential Revision: D63738952
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63738952

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6f17947.

@Olivia-liu
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c docs

@pytorchbot
Copy link
Collaborator

Cherry picking #5809

Command git -C /home/runner/work/executorch/executorch cherry-pick -x -X theirs 6f179472b866070a5207b0ff5475061d467cb6d7 returned non-zero exit code 1

Auto-merging docs/source/extension-module.md
Auto-merging docs/source/index.rst
Auto-merging docs/source/llm/getting-started.md
CONFLICT (modify/delete): docs/source/model-debugging.md deleted in HEAD and modified in 6f179472b (New URL for the ETDump page (#5809)).  Version 6f179472b (New URL for the ETDump page (#5809)) of docs/source/model-debugging.md left in tree.
Auto-merging docs/source/tutorials_source/devtools-integration-tutorial.py
Auto-merging extension/pybindings/pybindings.pyi
error: could not apply 6f179472b... New URL for the ETDump page (#5809)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@Olivia-liu
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c docs

pytorchbot pushed a commit that referenced this pull request Oct 7, 2024
Summary:
Pull Request resolved: #5809

This diff is to rename the "sdk-etdump" documentation page to just "etdump".

Old URL: https://pytorch.org/executorch/main/sdk-etdump.html
New URL ("sdk" is removed):
https://pytorch.org/executorch/main/etdump.html

Design doc: https://docs.google.com/document/d/1l6DYTq9Kq6VrPohruRFP-qScZDj01W_g4zlKyvqKGF4/edit?usp=sharing

Reviewed By: dbort

Differential Revision: D63738952

fbshipit-source-id: dda59dc74512aacd2ad168a36e567556b44baa2f
(cherry picked from commit 6f17947)
@pytorchbot
Copy link
Collaborator

Cherry picking #5809

The cherry pick PR is at #5938 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

jackzhxng pushed a commit that referenced this pull request Oct 7, 2024
New URL for the ETDump page (#5809)

Summary:
Pull Request resolved: #5809

This diff is to rename the "sdk-etdump" documentation page to just "etdump".

Old URL: https://pytorch.org/executorch/main/sdk-etdump.html
New URL ("sdk" is removed):
https://pytorch.org/executorch/main/etdump.html

Design doc: https://docs.google.com/document/d/1l6DYTq9Kq6VrPohruRFP-qScZDj01W_g4zlKyvqKGF4/edit?usp=sharing

Reviewed By: dbort

Differential Revision: D63738952

fbshipit-source-id: dda59dc74512aacd2ad168a36e567556b44baa2f
(cherry picked from commit 6f17947)

Co-authored-by: Olivia Liu <olivialpx@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants