Arm backend: Change run.sh to let cmake decide number of parallel jobs #5813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of specifying number of parallel jobs let cmake decide for it self. This make this script work better on macOS and might speed up builds as more parallel jobs are used. Signed-off-by: Zingo Andersen <zingo.andersen@arm.com> Change-Id: I33c501f6b441fd68aaef47d0169fb5eb0d254718
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5813
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit aa8428b with merge base 393553c ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
the
partner: arm
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
digantdesai
reviewed
Oct 3, 2024
|
|
||
| n=$(nproc) | ||
| cmake --build cmake-out-aot-lib -j"$((n - 5))" -- quantized_ops_aot_lib | ||
| cmake --build cmake-out-aot-lib --parallel -- quantized_ops_aot_lib |
Contributor
There was a problem hiding this comment.
Ok for now, if i were to guess --parallel or -j might push oom? n - 5 may be too conservative. Let's see how this fare.
Collaborator
Author
There was a problem hiding this comment.
My thinking also, lets see if its a problem
digantdesai
approved these changes
Oct 3, 2024
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@digantdesai merged this pull request in 3da2658. |
zingo
deleted the
Arm-backend-Change-run.sh-to-let-cmake-decide-number-of-parallel-jobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of specifying number of parallel jobs let cmake decide for it self. This make this script work better on macOS and might speed up builds as more parallel jobs are used.