Skip to content

Arm backend: Change run.sh to let cmake decide number of parallel jobs #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Arm backend: Change run.sh to let cmake decide number of parallel jobs #5813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions examples/arm/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ function build_quantization_aot_lib()
-Bcmake-out-aot-lib \
"${et_root_dir}"

n=$(nproc)
cmake --build cmake-out-aot-lib -j"$((n - 5))" -- quantized_ops_aot_lib
cmake --build cmake-out-aot-lib --parallel -- quantized_ops_aot_lib
Copy link
Contributor

@digantdesai digantdesai Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now, if i were to guess --parallel or -j might push oom? n - 5 may be too conservative. Let's see how this fare.

Copy link
Collaborator Author

@zingo zingo Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking also, lets see if its a problem

}


Expand Down Expand Up @@ -147,8 +146,7 @@ function build_executorch() {

echo "[${FUNCNAME[0]}] Configured CMAKE"

n=$(nproc)
cmake --build ${et_build_dir} -j"$((n - 5))" --target install --config Release
cmake --build ${et_build_dir} --parallel --target install --config Release

cmake \
-DCMAKE_INSTALL_PREFIX=${et_build_dir} \
Expand All @@ -158,7 +156,7 @@ function build_executorch() {
-DCMAKE_TOOLCHAIN_FILE="${toolchain_cmake}" \
-B"${et_build_dir}"/examples/arm \
"${et_root_dir}"/examples/arm
cmake --build ${et_build_dir}/examples/arm -- -j"$((n - 5))"
cmake --build ${et_build_dir}/examples/arm --parallel --

set +x

Expand Down Expand Up @@ -189,8 +187,7 @@ function build_executorch_runner() {
-DPYTHON_EXECUTABLE=$(which python3)
echo "[${FUNCNAME[0]}] Configured CMAKE"

n=$(nproc)
cmake --build ${executor_runner_path}/cmake-out -- -j"$((n - 5))" arm_executor_runner
cmake --build ${executor_runner_path}/cmake-out --parallel -- arm_executor_runner
echo "[${FUNCNAME[0]}] Generated baremetal elf file:"
find ${executor_runner_path}/cmake-out -name "arm_executor_runner"
echo "executable_text: $(find ${executor_runner_path}/cmake-out -name arm_executor_runner -exec size {} \; | grep -v filename | awk '{print $1}') bytes"
Expand Down
Loading