Skip to content

Correct Core ML perf metrics #5862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Correct Core ML perf metrics #5862

wants to merge 1 commit into from

Conversation

@guangy10
Copy link
Contributor

@guangy10 guangy10 commented Oct 4, 2024

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5862

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7a905d3 with merge base 34e7ad8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2024
@guangy10 guangy10 requested review from huydhn and shoumikhin October 4, 2024 00:39
@guangy10 guangy10 marked this pull request as ready for review October 4, 2024 00:39
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2024

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the correct_coreml_metrics branch from 1d49d94 to 25c4703 Compare October 4, 2024 00:57
@guangy10 guangy10 force-pushed the correct_coreml_metrics branch from 25c4703 to 7a905d3 Compare October 4, 2024 20:51
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2024

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2024

@guangy10 merged this pull request in 784eb51.

@guangy10
Copy link
Contributor Author

guangy10 commented Oct 8, 2024

@pytorchbot cherry-pick --onto release/0.4 -c docs

@guangy10 guangy10 deleted the correct_coreml_metrics branch October 8, 2024 21:07
pytorchbot pushed a commit that referenced this pull request Oct 8, 2024
@pytorchbot
Correct Core ML perf metrics (#5862)
2a609f9 
Summary: Pull Request resolved: #5862

Reviewed By: huydhn

Differential Revision: D63873696

Pulled By: guangy10

fbshipit-source-id: e4cb20c0a87b01d9c78dce085dad6f97bcf03b28
(cherry picked from commit 784eb51)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Oct 8, 2024

Cherry picking #5862

The cherry pick PR is at #6000 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 8, 2024
Closed
jackzhxng pushed a commit that referenced this pull request Oct 9, 2024
@pytorchbot
Correct Core ML perf metrics (#6000)
ed7e65f 
Correct Core ML perf metrics (#5862)

Summary: Pull Request resolved: #5862

Reviewed By: huydhn

Differential Revision: D63873696

Pulled By: guangy10

fbshipit-source-id: e4cb20c0a87b01d9c78dce085dad6f97bcf03b28
(cherry picked from commit 784eb51)

Co-authored-by: Guang Yang <guangyang@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@shoumikhin shoumikhin Awaiting requested review from shoumikhin

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guangy10 @facebook-github-bot @pytorchbot @huydhn