Fix QA issues of the devtools README #5963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D64017662
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5963
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit abd2751 with merge base 7337f8e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64017662 |
Gasoonjia
approved these changes
Oct 8, 2024
Contributor
|
This pull request has been merged in 085193e. |
Contributor
Author
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Summary: Pull Request resolved: #5963 Add new files in the "Directory structure". And also remove an old statement. Since `-DEXECUTORCH_BUILD_DEVTOOLS=ON` is set in the build_example_runner.sh, and not in a command in the readme, so it no longer makes sense to call it out in this readme. Reviewed By: Gasoonjia Differential Revision: D64017662 fbshipit-source-id: 1ee8b086180c7f995ff3306ebceb4afcff934214 (cherry picked from commit 085193e)
Collaborator
Cherry picking #5963The cherry pick PR is at #5998 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fix QA issues of the devtools README (#5963) Summary: Pull Request resolved: #5963 Add new files in the "Directory structure". And also remove an old statement. Since `-DEXECUTORCH_BUILD_DEVTOOLS=ON` is set in the build_example_runner.sh, and not in a command in the readme, so it no longer makes sense to call it out in this readme. Reviewed By: Gasoonjia Differential Revision: D64017662 fbshipit-source-id: 1ee8b086180c7f995ff3306ebceb4afcff934214 (cherry picked from commit 085193e) Co-authored-by: Olivia Liu <olivialpx@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D64017662