Fix QA issues of the devtools README #5998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: #5963 Add new files in the "Directory structure". And also remove an old statement. Since `-DEXECUTORCH_BUILD_DEVTOOLS=ON` is set in the build_example_runner.sh, and not in a command in the readme, so it no longer makes sense to call it out in this readme. Reviewed By: Gasoonjia Differential Revision: D64017662 fbshipit-source-id: 1ee8b086180c7f995ff3306ebceb4afcff934214 (cherry picked from commit 085193e)
This was referenced Oct 8, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5998
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit daedeb6 with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D64017662