Skip to content

Update build framework script to skip specifying buck executable. #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update build framework script to skip specifying buck executable. #5985

wants to merge 1 commit into from

Conversation

@shoumikhin
Copy link
Contributor

@shoumikhin shoumikhin commented Oct 8, 2024

Summary: .

Differential Revision: D64053120

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5985

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit e861489 with merge base c5fdebd (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D64053120

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D64053120

@shoumikhin @facebook-github-bot
Update build framework script to skip specifying buck executable. (#5985
e861489 
)

Summary:

.

Reviewed By: dbort

Differential Revision: D64053120
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D64053120

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 8, 2024

This pull request has been merged in f663ba6.

@shoumikhin
Copy link
Contributor Author

shoumikhin commented Oct 8, 2024

@pytorchbot cherry-pick --onto release/0.4 -c critical

pytorchbot pushed a commit that referenced this pull request Oct 8, 2024
@shoumikhin @pytorchbot
Update build framework script to skip specifying buck executable. (#5985
6932f7c 
)

Summary:
Pull Request resolved: #5985

.

Reviewed By: dbort

Differential Revision: D64053120

fbshipit-source-id: fc4149ee13130f913f96768a1370ea40ce8ed8b7
(cherry picked from commit f663ba6)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Oct 8, 2024

Cherry picking #5985

The cherry pick PR is at #6004 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 8, 2024
Closed
jackzhxng pushed a commit that referenced this pull request Oct 9, 2024
@pytorchbot @shoumikhin
Update build framework script to skip specifying buck executable. (#6004
f4bbf19 
)

Update build framework script to skip specifying buck executable. (#5985)

Summary:
Pull Request resolved: #5985

.

Reviewed By: dbort

Differential Revision: D64053120

fbshipit-source-id: fc4149ee13130f913f96768a1370ea40ce8ed8b7
(cherry picked from commit f663ba6)

Co-authored-by: Anthony Shoumikhin <shoumikhin@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shoumikhin @facebook-github-bot @pytorchbot