Skip to content

Add reduce_sum op to ArmBackend #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add reduce_sum op to ArmBackend #6044

wants to merge 1 commit into from

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Oct 9, 2024

Adds node visitor, tests and annotator

Change-Id: I002f5203e855b9489fc5e67095ec30b2b3ce0077

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6044

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7b5d925 with merge base 83c95df (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 9, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
digantdesai
digantdesai approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR. Thanks @Erik-Lundell.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 9, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

digantdesai commented Oct 9, 2024

Internal test failure.

/executorch/backends/arm/quantizer/quantization_annotation/sum_annotator.py:48:12 Incompatible parameter type [6]: In call `torch.ao.quantization.quantizer.quantizer.QuantizationAnnotation.__init__`, for argument `input_qspec_map`, expected `Dict[Node, Optional[QuantizationSpecBase]]` but got `Dict[Node, Optional[QuantizationSpec]]`.

@Erik-Lundell
Add reduce_sum op to ArmBackend
7b5d925 
Adds node visitor, tests and annotator

Change-Id: I002f5203e855b9489fc5e67095ec30b2b3ce0077
@Erik-Lundell
Copy link
Collaborator Author

Erik-Lundell commented Oct 10, 2024

Internal test failure.

/executorch/backends/arm/quantizer/quantization_annotation/sum_annotator.py:48:12 Incompatible parameter type [6]: In call `torch.ao.quantization.quantizer.quantizer.QuantizationAnnotation.__init__`, for argument `input_qspec_map`, expected `Dict[Node, Optional[QuantizationSpecBase]]` but got `Dict[Node, Optional[QuantizationSpec]]`.

I am not sure why that would be an error since QuantizationSpec inherits from QuantizationSpecBase, am I missing something? I rebased and tried adding a cast, but I don't know if it affects the type checker/ why it would be needed.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 15, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 16, 2024

@digantdesai merged this pull request in 35aeaca.

@Erik-Lundell Erik-Lundell deleted the op_sum branch July 31, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Erik-Lundell @facebook-github-bot @digantdesai