Arm backend: Add tanh operator #6226
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6226
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8620371 with merge base ca47839 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label 'partner: arm' |
pytorch-bot
bot
added
the
partner: arm
| def tanh(x): | ||
| # Convert quantized input to floating point tanh input space. | ||
| v = dequantize_value(x, in_quantargs) | ||
| # Compute tanh. |
There was a problem hiding this comment.
curious why not numpy.tanh or torch.nn.Tanh?
There was a problem hiding this comment.
Hi,
Thanks for review! I just kept this consistent with sigmoid.: #4114
I am happy to update this though if needed.
Thanks,
Saoirse
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Seems like a flaky CI - rerunning it. |
|
Rebase please? CI seems happy now |
Thanks, done! |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3 participants
Adds Tanh operator to the Arm backend including unit tests