Skip to content

Conversation

@varunchariArm
Copy link
Contributor

Summary:
Updating the Arm delegate documentation to support Crostone 320 FVP and additional options in run.sh script

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6230

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 84a3458 with merge base 7ba7990 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @varunchariArm!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@digantdesai digantdesai added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Oct 15, 2024
@digantdesai
Copy link
Contributor

Looks good at a high level, lets address some of these comments.

@digantdesai
Copy link
Contributor

Also @varunchariArm - The author does not have a valid CLA on file.!

@varunchariArm
Copy link
Contributor Author

Also @varunchariArm - The author does not have a valid CLA on file.!

Submitted request to get CLA.

@digantdesai
Copy link
Contributor

FYI can't merge until CLA goes through

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2024
@varunchariArm
Copy link
Contributor Author

HI Digant,
Seems like CLA is signed, can you please review the PR?
Thanks

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit ffad824 into pytorch:main Oct 30, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants