Skip to content

Conversation

@kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Oct 23, 2024

Add workflow_call trigger.

android.yml takes about 20 minutes and it's not expensive as before

Later we are considering use a matcher to check whether we should bypass

Later we plan to upload exported models and use it on Android E2E

Add workflow_call trigger.

android.yml takes about 20 minutes and it's not expensive as before
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6449

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 6f411c3 with merge base fe20be9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2024
@kirklandsign kirklandsign requested a review from huydhn October 23, 2024 00:29
fi
android:
uses: ./.github/workflows/_android.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm too blame here but I'm bit concern about the usage of a metal instances like c7i.metal-24xl to run the emulator. That one is way over spec (and AWS doesn't provide smaller size metal instance). And with it running in pull, it could has a negative impact on the bill. I think let's try to switch back to a smaller instance there, linux.4xlarge. The emulator test might take 10 more minute to finish IIRC, but that's probably ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that 4xlarge doesn't work but 12xlarge works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, 12xlarge is ok too

@kirklandsign kirklandsign merged commit 6a1772d into main Oct 23, 2024
46 checks passed
@kirklandsign kirklandsign deleted the android-test-trigger-2 branch October 23, 2024 21:07
larryliu0820 added a commit that referenced this pull request Oct 28, 2024
After #6449 we should not require "Android" jobs to pass because they are merged into "pull" jobs.
larryliu0820 added a commit that referenced this pull request Oct 28, 2024
After #6449 we should not require "Android" jobs to pass because they are merged into "pull" jobs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants