-
Notifications
You must be signed in to change notification settings - Fork 724
Move android.yml to pull.yml #6449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add workflow_call trigger. android.yml takes about 20 minutes and it's not expensive as before
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6449
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 6f411c3 with merge base fe20be9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| fi | ||
| android: | ||
| uses: ./.github/workflows/_android.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm too blame here but I'm bit concern about the usage of a metal instances like c7i.metal-24xl to run the emulator. That one is way over spec (and AWS doesn't provide smaller size metal instance). And with it running in pull, it could has a negative impact on the bill. I think let's try to switch back to a smaller instance there, linux.4xlarge. The emulator test might take 10 more minute to finish IIRC, but that's probably ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that 4xlarge doesn't work but 12xlarge works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, 12xlarge is ok too
After #6449 we should not require "Android" jobs to pass because they are merged into "pull" jobs.
After #6449 we should not require "Android" jobs to pass because they are merged into "pull" jobs.
Add workflow_call trigger.
android.yml takes about 20 minutes and it's not expensive as before
Later we are considering use a matcher to check whether we should bypass
Later we plan to upload exported models and use it on Android E2E