Skip to content

Move android.yml to pull.yml #6449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Move android.yml to pull.yml #6449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
405e50c
Move android.yml to pull.yml
kirklandsign Oct 23, 2024
2353cde
Update _android.yml
kirklandsign Oct 23, 2024
6f411c3
Try 12xlarge
kirklandsign Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions .github/workflows/android.yml → .github/workflows/_android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,7 @@
name: Android

on:
push:
branches:
- main
- release/*
tags:
- ciflow/android/*
pull_request:
paths:
- .ci/docker/**
- .github/workflows/android.yml
- build/*android*.sh
- install_requirements.sh
- examples/demo-apps/android/**
- extension/android/**
- extension/benchmark/android/**
- extension/module/**
workflow_call:
workflow_dispatch:

concurrency:
Expand Down Expand Up @@ -51,7 +36,7 @@ jobs:
run-emulator:
needs: build-llm-demo
# NB: Use metal install for KVM support to run the emulator faster
runs-on: linux.24xl.spr-metal
runs-on: linux.12xlarge
env:
ANDROID_NDK_VERSION: r27b
API_LEVEL: 34
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,9 @@ jobs:
exit 1
fi

android:
uses: ./.github/workflows/_android.yml
Copy link
Contributor

@huydhn huydhn Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm too blame here but I'm bit concern about the usage of a metal instances like c7i.metal-24xl to run the emulator. That one is way over spec (and AWS doesn't provide smaller size metal instance). And with it running in pull, it could has a negative impact on the bill. I think let's try to switch back to a smaller instance there, linux.4xlarge. The emulator test might take 10 more minute to finish IIRC, but that's probably ok.

Copy link
Contributor Author

@kirklandsign kirklandsign Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that 4xlarge doesn't work but 12xlarge works

Copy link
Contributor

@huydhn huydhn Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, 12xlarge is ok too


unittest:
uses: ./.github/workflows/_unittest.yml
with:
Expand Down
Loading