Replace torch.empty with torch.zeros #6478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6478
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ce906a1 with merge base e93ad5f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64875312 |
helunwencser
pushed a commit
to helunwencser/ao
that referenced
this pull request
Oct 25, 2024
Summary: X-link: pytorch/executorch#6478 It turns out that it is unsafe to use `torch.empty` in oss environment because `torch.empty` creates tensor with uninitialized data. That means the buffer could be initialized with random values depends on what is left on that piece of memory. This causes code to generate inconsistent behavior. This PR replaces `torch.empty` with `torch.zeros` to make sure that they are properly initialized and avoid inconsistent behaviors. Reviewed By: msaroufim Differential Revision: D64875312
helunwencser
force-pushed
the
export-D64875312
branch
from
8aa7d11 to
c74b0b7
Compare
helunwencser
pushed a commit
to helunwencser/executorch
that referenced
this pull request
Oct 25, 2024
Summary: X-link: pytorch/ao#1157 It turns out that it is unsafe to use `torch.empty` in oss environment because `torch.empty` creates tensor with uninitialized data. That means the buffer could be initialized with random values depends on what is left on that piece of memory. This causes code to generate inconsistent behavior. This PR replaces `torch.empty` with `torch.zeros` to make sure that they are properly initialized and avoid inconsistent behaviors. Reviewed By: msaroufim Differential Revision: D64875312
|
This pull request was exported from Phabricator. Differential Revision: D64875312 |
helunwencser
pushed a commit
to helunwencser/ao
that referenced
this pull request
Oct 25, 2024
Summary: X-link: pytorch/executorch#6478 It turns out that it is unsafe to use `torch.empty` in oss environment because `torch.empty` creates tensor with uninitialized data. That means the buffer could be initialized with random values depends on what is left on that piece of memory. This causes code to generate inconsistent behavior. This PR replaces `torch.empty` with `torch.zeros` to make sure that they are properly initialized and avoid inconsistent behaviors. Reviewed By: msaroufim Differential Revision: D64875312
helunwencser
pushed a commit
to helunwencser/executorch
that referenced
this pull request
Oct 25, 2024
Summary: X-link: pytorch/ao#1157 It turns out that it is unsafe to use `torch.empty` in oss environment because `torch.empty` creates tensor with uninitialized data. That means the buffer could be initialized with random values depends on what is left on that piece of memory. This causes code to generate inconsistent behavior. This PR replaces `torch.empty` with `torch.zeros` to make sure that they are properly initialized and avoid inconsistent behaviors. Reviewed By: msaroufim Differential Revision: D64875312
helunwencser
force-pushed
the
export-D64875312
branch
from
c74b0b7 to
c5ede25
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64875312 |
helunwencser
pushed a commit
to helunwencser/ao
that referenced
this pull request
Oct 25, 2024
Summary: X-link: pytorch/executorch#6478 It turns out that it is unsafe to use `torch.empty` in oss environment because `torch.empty` creates tensor with uninitialized data. That means the buffer could be initialized with random values depends on what is left on that piece of memory. This causes code to generate inconsistent behavior. This PR replaces `torch.empty` with `torch.zeros` to make sure that they are properly initialized and avoid inconsistent behaviors. Reviewed By: msaroufim Differential Revision: D64875312
Summary: X-link: pytorch/ao#1157 It turns out that it is unsafe to use `torch.empty` in oss environment because `torch.empty` creates tensor with uninitialized data. That means the buffer could be initialized with random values depends on what is left on that piece of memory. This causes code to generate inconsistent behavior. This PR replaces `torch.empty` with `torch.zeros` to make sure that they are properly initialized and avoid inconsistent behaviors. Reviewed By: msaroufim Differential Revision: D64875312
helunwencser
force-pushed
the
export-D64875312
branch
from
c5ede25 to
ce906a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64875312 |
mergennachin
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It turns out that it is unsafe to use
torch.emptyin oss environment becausetorch.emptycreates tensor with uninitialized data. That means the buffer could be initialized with random values depends on what is left on that piece of memory. This causes code to generate inconsistent behavior.This PR replaces
torch.emptywithtorch.zerosto make sure that they are properly initialized and avoid inconsistent behaviors.Differential Revision: D64875312