Remove buck2 CI from pull.yml #6539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep one model E2E (mv3) from gather_models only for basic validation We removed all buck2 from docs already
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6539
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d524277 with merge base 3b25b05 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
huydhn
reviewed
Oct 29, 2024
| test-setup-linux-gcc: | ||
| name: test-setup-linux-gcc | ||
| uses: pytorch/test-infra/.github/workflows/linux_job.yml@main | ||
| strategy: |
There was a problem hiding this comment.
I think you could just remove this strategy section, it does nothing now
There was a problem hiding this comment.
There is a fail-fast: false below
huydhn
reviewed
Oct 29, 2024
.github/workflows/pull.yml
Outdated
| # Setup executorch | ||
| PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh buck2 | ||
| PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh cmake |
There was a problem hiding this comment.
Nit: Use ${BUILD_TOOL} here?
huydhn
reviewed
Oct 29, 2024
.github/workflows/pull.yml
Outdated
| # Setup executorch | ||
| PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh buck2 | ||
| PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh cmake |
There was a problem hiding this comment.
Nit: Use ${BUILD_TOOL} here?
huydhn
approved these changes
Oct 29, 2024
|
Saves >30 minutes CPU time for each pull.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep one model E2E (mv3) from gather_models only for basic validation
We removed all buck2 from docs already
Test: CI