Skip to content

Arm backend: make tag_io_quant_pass tag all output dq-nodes #6547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Arm backend: make tag_io_quant_pass tag all output dq-nodes #6547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backends/arm/_passes/tag_io_quant_pass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ def call(self, graph_module: torch.fx.GraphModule):

# tag dq of outputs
if node.op == "output":
quant, *_ = node.args[0]
if self.is_dequant_node(quant):
quant.meta["arm_override_partition"] = False
for quant in node.args[0]:
if self.is_dequant_node(quant):
quant.meta["arm_override_partition"] = False

graph_module.recompile()
return PassResult(graph_module, True)
18 changes: 9 additions & 9 deletions backends/arm/test/passes/test_tag_io_quant_pass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
from executorch.backends.arm.test.tester.arm_tester import ArmTester


class Add(torch.nn.Module):
class TwoInputsTwoOutputs(torch.nn.Module):

def get_inputs(self):
return (torch.rand(1, 10, 10, 10),)
return (torch.rand(1, 10, 10, 10), (torch.rand(1, 10, 10, 10)))

def forward(self, x):
return x + x
def forward(self, x, y):
return (x + y, x * y)


class TestTagIOQuantPass(unittest.TestCase):
Expand All @@ -36,29 +36,29 @@ def _tosa_BI_u55_pipeline(self, module: torch.nn.Module):
.to_edge()
.check_count(
{
"executorch_exir_dialects_edge__ops_quantized_decomposed_quantize_per_tensor_default": 2
"executorch_exir_dialects_edge__ops_quantized_decomposed_quantize_per_tensor_default": 4
}
)
.check_count(
{
"executorch_exir_dialects_edge__ops_quantized_decomposed_dequantize_per_tensor_default": 2
"executorch_exir_dialects_edge__ops_quantized_decomposed_dequantize_per_tensor_default": 6
}
)
.partition()
.check_count(
{
"executorch_exir_dialects_edge__ops_quantized_decomposed_quantize_per_tensor_default": 1
"executorch_exir_dialects_edge__ops_quantized_decomposed_quantize_per_tensor_default": 2
}
)
.check_count({"torch.ops.higher_order.executorch_call_delegate": 1})
.check_count(
{
"executorch_exir_dialects_edge__ops_quantized_decomposed_dequantize_per_tensor_default": 1
"executorch_exir_dialects_edge__ops_quantized_decomposed_dequantize_per_tensor_default": 2
}
)
# .to_executorch() requires additional steps
)

def test_BI_u55_artifact(self):
model = Add()
model = TwoInputsTwoOutputs()
self._tosa_BI_u55_pipeline(model)
Loading