Add per_tensor overload for quantized_layer_norm #6554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6554
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25d848b with merge base c4b4e98 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65151427 |
mcremon-meta
added a commit
that referenced
this pull request
Oct 29, 2024
Summary: This will improve performance by removing some `full` ops Differential Revision: D65151427
mcremon-meta
force-pushed
the
export-D65151427
branch
from
ede0541 to
2502123
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65151427 |
dulinriley
approved these changes
Oct 29, 2024
Comment on lines
+192
to
+195
| ET_CHECK_MSG( | ||
| false, | ||
| "Unhandled input dtype %hhd", | ||
| static_cast<int8_t>(input.scalar_type())); |
There was a problem hiding this comment.
Use ET_KERNEL_CHECK instead for better error messages
Suggested change
| ET_CHECK_MSG( | |
| false, | |
| "Unhandled input dtype %hhd", | |
| static_cast<int8_t>(input.scalar_type())); | |
| ET_KERNEL_CHECK( | |
| context, | |
| false, | |
| InvalidArgument, | |
| out); |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
Summary: This will improve performance by removing some `full` ops Reviewed By: dulinriley Differential Revision: D65151427
facebook-github-bot
force-pushed
the
export-D65151427
branch
from
2502123 to
1a93922
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65151427 |
mcremon-meta
added a commit
that referenced
this pull request
Oct 31, 2024
Summary: This will improve performance by removing some `full` ops Reviewed By: dulinriley Differential Revision: D65151427
mcremon-meta
force-pushed
the
export-D65151427
branch
from
1a93922 to
0b160bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65151427 |
Summary: This will improve performance by removing some `full` ops Reviewed By: dulinriley Differential Revision: D65151427
mcremon-meta
force-pushed
the
export-D65151427
branch
from
0b160bc to
25d848b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65151427 |
tarun292
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This will improve performance by removing some
fullopsDifferential Revision: D65151427