Remove deprecated InstructTemplate from llm_pte_finetuning example #6557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6557
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d19d1b8 with merge base f0463c4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@RdoubleA has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Oct 29, 2024
Contributor
larryliu0820
left a comment
larryliu0820
left a comment
There was a problem hiding this comment.
Stamping since this is blocking. Please fix internal job failure
RdoubleA
force-pushed
the
remove_instruct_template
branch
from
e9e2343 to
41721dd
Compare
RdoubleA
added a commit
to RdoubleA/executorch
that referenced
this pull request
Oct 29, 2024
…ytorch#6557) Summary: See pytorch#6552 for context. Here, we remove the InstructTemplate classes and instead directly replace with a dataset builder that uses the necessary torchtune data components. The associated config is also updated. Reviewed By: larryliu0820 Differential Revision: D65168404 Pulled By: RdoubleA
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65168404 |
…ytorch#6557) Summary: See pytorch#6552 for context. Here, we remove the InstructTemplate classes and instead directly replace with a dataset builder that uses the necessary torchtune data components. The associated config is also updated. Reviewed By: larryliu0820 Differential Revision: D65168404 Pulled By: RdoubleA
RdoubleA
force-pushed
the
remove_instruct_template
branch
from
41721dd to
d19d1b8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65168404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6552 for context.
Here, we remove the InstructTemplate classes and instead directly replace with a dataset builder that uses the necessary torchtune data components. The associated config is also updated.
Closes #6552.