Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #6600
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/135/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/135/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/131/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/135/orig
@diff-train-skip-merge

Pull Request resolved: #6577

## Changes

The goal of this diff is to enforce a specific structure in how graph transform passes are applied during `vulkan_preprocess`. This will help make sure that certain passes are applied at the correct time, and that pre-requisite conditions for passes are fulfilled before they are applied.

See the comments in `vulkan_preprocess.py` for more details.
ghstack-source-id: 251223076

Differential Revision: [D65234843](https://our.internmc.facebook.com/intern/diff/D65234843/)
Pull Request resolved: #6600

## Changes

As title. Introduce a common Python utility library for scripts in the Vulkan backend.
ghstack-source-id: 251223077

Differential Revision: [D65291064](https://our.internmc.facebook.com/intern/diff/D65291064/)
@pytorch-bot pytorch-bot bot added ciflow/periodic module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ labels Oct 31, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6605

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3792c79 with merge base 1972e69 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2024
Base automatically changed from gh/SS-JIA/131/orig to main October 31, 2024 23:53
@kirklandsign kirklandsign merged commit 91c382d into main Oct 31, 2024
80 of 81 checks passed
@kirklandsign kirklandsign deleted the gh/SS-JIA/135/orig branch October 31, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants