Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Nov 14, 2024

test_attention.py and test_position_embeddings for aoti are flaky

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6861

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 2ab367f with merge base 71612a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 14, 2024
@lucylq lucylq marked this pull request as ready for review November 14, 2024 19:24
@lucylq lucylq requested a review from larryliu0820 November 14, 2024 19:24
@lucylq lucylq force-pushed the lfq.disable-llm-module-test branch from f3d2e5d to 3573823 Compare November 14, 2024 19:31

self.assertTrue(torch.allclose(y, ref_y))

@unittest.skip(reason="TODO(T207740932): test is flaky")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is fine right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully 🙏

@lucylq lucylq force-pushed the lfq.disable-llm-module-test branch from 3573823 to 2ab367f Compare November 14, 2024 19:35
@larryliu0820 larryliu0820 merged commit fc6d097 into main Nov 14, 2024
38 checks passed
@larryliu0820 larryliu0820 deleted the lfq.disable-llm-module-test branch November 14, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants