Only use LINEAR tiling if it's available
#6902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Context Recently, we switched to using `VK_IMAGE_TILING_LINEAR` to minimize memory footprint. However, according to the [Vulkan Spec](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkImageCreateInfo.html) the `VK_IMAGE_TILING_LINEAR` tiling may only be available for 2D textures. ## Changes * When constructing the `Adapter` class, check if it's possible to create a 3D texture with LINEAR tiling * Add a way to query preferred tiling from `Context` * Construct VkImage with the preferred tiling. Reviewed By: yipjustin Differential Revision: D66029137
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6902
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 80c89b5 with merge base 0877926 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66029137 |
junpi3
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Recently, we switched to using
VK_IMAGE_TILING_LINEARto minimize memory footprint.However, according to the Vulkan Spec the
VK_IMAGE_TILING_LINEARtiling may only be available for 2D textures.Changes
Adapterclass, check if it's possible to create a 3D texture with LINEAR tilingContextReviewed By: yipjustin
Differential Revision: D66029137