Add portable upsample_bilinear2d kernel #6923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6923
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1e4e960 with merge base 82763a9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65756150 |
GregoryComer
force-pushed
the
export-D65756150
branch
from
6e084a7 to
68691f8
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Nov 19, 2024
Summary: Add a upsample_bilinear2d kernel to the portable kernel library. This implementation re-uses some of the inner logic from the ATen implementation (see Upsample.h and UpsampleKernel.cpp), however I have not ported the outer kernel structure as it relies on TensorIterator and runtime allocation. It may be worth re-visiting this in the future, either by looking at pulling in more of the ATen implementation or adding an optimized variant. Differential Revision: D65756150 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65756150
branch
from
68691f8 to
f46d433
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65756150 |
GregoryComer
added
the
release notes: ops & kernels
GregoryComer
force-pushed
the
export-D65756150
branch
from
f46d433 to
21b4bca
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 3, 2024
Summary: Add a upsample_bilinear2d kernel to the portable kernel library. This implementation re-uses some of the inner logic from the ATen implementation (see Upsample.h and UpsampleKernel.cpp), however I have not ported the outer kernel structure as it relies on TensorIterator and runtime allocation. It may be worth re-visiting this in the future, either by looking at pulling in more of the ATen implementation or adding an optimized variant. Test Plan: Added comprehensive operator-level test coverage for upsample_bilinear2d. ``` buck test //executorch/kernels/test:portable_op_upsample_bilinear2d_test buck test //executorch/kernels/test:aten_op_upsample_bilinear2d_test ``` Differential Revision: D65756150 Pulled By: GregoryComer
|
This pull request was exported from Phabricator. Differential Revision: D65756150 |
GregoryComer
force-pushed
the
export-D65756150
branch
from
21b4bca to
25e41c8
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 8, 2024
Summary: Add a upsample_bilinear2d kernel to the portable kernel library. This implementation re-uses some of the inner logic from the ATen implementation (see Upsample.h and UpsampleKernel.cpp), however I have not ported the outer kernel structure as it relies on TensorIterator and runtime allocation. It may be worth re-visiting this in the future, either by looking at pulling in more of the ATen implementation or adding an optimized variant. Test Plan: Added comprehensive operator-level test coverage for upsample_bilinear2d. ``` buck test //executorch/kernels/test:portable_op_upsample_bilinear2d_test buck test //executorch/kernels/test:aten_op_upsample_bilinear2d_test ``` Differential Revision: D65756150 Pulled By: GregoryComer
|
This pull request was exported from Phabricator. Differential Revision: D65756150 |
manuelcandales
approved these changes
Dec 12, 2024
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 21, 2024
Summary: Add a upsample_bilinear2d kernel to the portable kernel library. This implementation re-uses some of the inner logic from the ATen implementation (see Upsample.h and UpsampleKernel.cpp), however I have not ported the outer kernel structure as it relies on TensorIterator and runtime allocation. It may be worth re-visiting this in the future, either by looking at pulling in more of the ATen implementation or adding an optimized variant. Test Plan: Added comprehensive operator-level test coverage for upsample_bilinear2d. ``` buck test //executorch/kernels/test:portable_op_upsample_bilinear2d_test buck test //executorch/kernels/test:aten_op_upsample_bilinear2d_test ``` Reviewed By: manuelcandales Differential Revision: D65756150 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65756150
branch
from
25e41c8 to
3646388
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65756150 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 23, 2024
Summary: Add a upsample_bilinear2d kernel to the portable kernel library. This implementation re-uses some of the inner logic from the ATen implementation (see Upsample.h and UpsampleKernel.cpp), however I have not ported the outer kernel structure as it relies on TensorIterator and runtime allocation. It may be worth re-visiting this in the future, either by looking at pulling in more of the ATen implementation or adding an optimized variant. Test Plan: Added comprehensive operator-level test coverage for upsample_bilinear2d. ``` buck test //executorch/kernels/test:portable_op_upsample_bilinear2d_test buck test //executorch/kernels/test:aten_op_upsample_bilinear2d_test ``` Reviewed By: manuelcandales Differential Revision: D65756150 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65756150
branch
from
3646388 to
ed78807
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65756150 |
Summary: Add a upsample_bilinear2d kernel to the portable kernel library. This implementation re-uses some of the inner logic from the ATen implementation (see Upsample.h and UpsampleKernel.cpp), however I have not ported the outer kernel structure as it relies on TensorIterator and runtime allocation. It may be worth re-visiting this in the future, either by looking at pulling in more of the ATen implementation or adding an optimized variant. Test Plan: Added comprehensive operator-level test coverage for upsample_bilinear2d. ``` buck test //executorch/kernels/test:portable_op_upsample_bilinear2d_test buck test //executorch/kernels/test:aten_op_upsample_bilinear2d_test ``` Reviewed By: manuelcandales Differential Revision: D65756150 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D65756150
branch
from
ed78807 to
1e4e960
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a upsample_bilinear2d kernel to the portable kernel library. This implementation re-uses some of the inner logic from the ATen implementation (see Upsample.h and UpsampleKernel.cpp), however I have not ported the outer kernel structure as it relies on TensorIterator and runtime allocation.
It may be worth re-visiting this in the future, either by looking at pulling in more of the ATen implementation or adding an optimized variant.
Differential Revision: D65756150