-
Notifications
You must be signed in to change notification settings - Fork 713
add Qualcomm SA8295 support #6986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6986
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 6523766 with merge base aa8d904 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @tianxf99! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@chiwwang hey can you help with reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort.
Could you help to rebase it?
6ccce31 to
6523766
Compare
|
I built it with qnn 2.20 version and have tested the deeplabv3 example on SA8295 soc and it works |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Maybe a rebase can make the merge process easier but this PR looks good for me.
[update] oh, never mind. I saw it is rebased!
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for more SoCs!
|
Hi @tianxf99, thank you for contributing! Just curious, what is your use case? |
Hey @tianxf99 glad to see this work. I'm the PM with the ExecuTorch team. Would love to know if you can share some context around why this PR matters for you and what you're trying to accomplish. |
Summary
Attempting to add Qualcomm SA8295 support. Noticed a prior attempt one year ago (#1196). If anyone is currently working on this, I'd be happy to collaborate! :D
Fixes
Fixes #1176