Skip to content

Conversation

@tianxf99
Copy link
Contributor

@tianxf99 tianxf99 commented Nov 20, 2024

Summary

Attempting to add Qualcomm SA8295 support. Noticed a prior attempt one year ago (#1196). If anyone is currently working on this, I'd be happy to collaborate! :D

Fixes

Fixes #1176

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6986

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 6523766 with merge base aa8d904 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @tianxf99!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@cccclai cccclai requested a review from chiwwang November 21, 2024 05:30
@cccclai
Copy link
Contributor

cccclai commented Nov 21, 2024

@chiwwang hey can you help with reviewing?

Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort.
Could you help to rebase it?

@tianxf99 tianxf99 force-pushed the qualcomm_support_SA8295 branch from 6ccce31 to 6523766 Compare November 21, 2024 06:20
@tianxf99
Copy link
Contributor Author

tianxf99 commented Nov 21, 2024

I built it with qnn 2.20 version and have tested the deeplabv3 example on SA8295 soc and it works

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@chiwwang chiwwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Maybe a rebase can make the merge process easier but this PR looks good for me.
[update] oh, never mind. I saw it is rebased!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for more SoCs!

@cccclai
Copy link
Contributor

cccclai commented Nov 21, 2024

Hi @tianxf99, thank you for contributing! Just curious, what is your use case?

@cccclai cccclai merged commit 0070680 into pytorch:main Nov 21, 2024
40 of 44 checks passed
@tianxf99 tianxf99 deleted the qualcomm_support_SA8295 branch November 24, 2024 08:00
@ali-khosh
Copy link

Summary

Attempting to add Qualcomm SA8295 support. Noticed a prior attempt one year ago (#1196). If anyone is currently working on this, I'd be happy to collaborate! :D

Fixes

Fixes #1176

Hey @tianxf99 glad to see this work. I'm the PM with the ExecuTorch team. Would love to know if you can share some context around why this PR matters for you and what you're trying to accomplish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support more Qualcomm SoCs

6 participants