Add Arm conformer unit test #7415
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7415
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit a8f523e with merge base 5f849ca ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
the
partner: arm
MI pass but with high tolerance on numerical accuracy. Change-Id: I6600eb09724d357edcea47898b612ee3229bb499 Signed-off-by: Fredrik Knutsson <fredrik.knutsson@arm.com>
freddan80
force-pushed
the
pr_draft_conformer
branch
from
5985c91 to
a8f523e
Compare
|
Love it ❤️ |
|
cc @limintang @3l1 |
| # Adjust nbr below as we increase op support. Note: most of the delegates | ||
| # calls are directly consecutive to each other in the .pte. The reason | ||
| # for that is some assert ops are removed by passes in the | ||
| # .to_executorch step, i.e. after Arm partitioner. |
There was a problem hiding this comment.
The reason for that is some assert ops are removed by passes in the .to_executorch step
One option is to partition them and delete them inside arm::delegate::preprocess()
| class TestConformer(unittest.TestCase): | ||
| """Tests Torchaudio Conformer""" | ||
|
|
||
| # Adjust nbr below as we increase op support. Note: most of the delegates |
Just FYI. This is the TorchAudio Conformer. It doesn't fully delegate as the sooftware conformer does. |
|
@freddan80 - why shouldn't we add https://github.com/sooftware/conformer in the CI? Since it delegates better than torchaudio? I remember you told me but can't remember why :p (may be because we prefer torchaudio?) |
4 participants
cc @digantdesai @per @zingo @oscarandersson8218