Fix mypy lintrunner #7534
Merged
Fix mypy lintrunner #7534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7534
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mergennachin
force-pushed
the
lintrunner_fix
branch
from
5499915 to
0270b88
Compare
tarun292
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we have duplicate subpackage names (e.g., backends/arm/quantizer, backends/qualcomm/quantizer)
If init.py is not given in parent directories, it doesn't resolve the packages unambiguously unless "explicit-package-bases" option is set.
https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-paths-to-modules
Issue: #7441
Test Plan
Before
Comment out
backends/**/*.py*, it was silently failing.After
It is failing, but with actual typechecker errors.