Skip to content

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Jan 21, 2025

Summary

Improve error message when no input/output quantization parameters are found for a given node. This will simplify debugging and tracing the root cause.

Change-Id: Id50641784f756a24241cc1f2d56de6a508102e12

cc @digantdesai @freddan80 @per @zingo

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7781

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c5d4e69 with merge base 91f09aa (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Jan 21, 2025
@oscarandersson8218 oscarandersson8218 force-pushed the qdq_folding_error_message branch from dc4a52e to 03879e0 Compare January 21, 2025 10:55
@oscarandersson8218 oscarandersson8218 changed the title Arm backend: Improve error msg when no qparams are found Arm backend: Improve error message when no qparams are found Jan 21, 2025
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: Id50641784f756a24241cc1f2d56de6a508102e12
@oscarandersson8218 oscarandersson8218 force-pushed the qdq_folding_error_message branch from 03879e0 to c5d4e69 Compare January 22, 2025 08:13
@zingo
Copy link
Collaborator

zingo commented Jan 22, 2025

fails seem unrelated to this PR (and fails in other PRs also)

@zingo zingo merged commit 4e63f0e into pytorch:main Jan 22, 2025
106 of 108 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Improve error msg when no qparams are found


Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
…#7781)

Improve error msg when no qparams are found


Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants