Skip to content

Conversation

@billmguo
Copy link
Contributor

@billmguo billmguo commented Jan 21, 2025

Summary: [OSS ET] Buck Fix to enable opt level = 3 for internal model export

Differential Revision: D68446241

@pytorchbot label "topic: not user facing"

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7793

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit 88d4c29 with merge base 7017e73 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68446241

@billmguo
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 22, 2025
)

Summary:

pytorch#7793
[OSS ET] Buck Fix to enable opt level = 3 for internal model export

Reviewed By: derekxu

Differential Revision: D68446241
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68446241

)

Summary:

pytorch#7793
[OSS ET] Buck Fix to enable opt level = 3 for internal model export

Reviewed By: derekxu

Differential Revision: D68446241
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68446241

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Maybe add some comments for the changes for future reference

@billmguo
Copy link
Contributor Author

  1. this PR make our internal build align with external one for AOT
  2. the PR make internal export model using -O3 same as external
  3. the PR make the internal export model enable QNN_HTP_CONTEXT_CONFIG_OPTION_WEIGHT_SHARING_ENABLED which align with external build

@facebook-github-bot facebook-github-bot merged commit a08d3f8 into pytorch:main Jan 22, 2025
45 of 47 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Differential Revision: D68446241

Pull Request resolved: #7793
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Differential Revision: D68446241

Pull Request resolved: pytorch#7793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants