Skip to content

Support Half/BFloat16 in roll #7861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Support Half/BFloat16 in roll #7861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kernels/portable/cpu/op_roll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Tensor& roll_out(

constexpr auto name = "roll.out";

ET_SWITCH_REALHB_TYPES(in.scalar_type(), ctx, name, CTYPE, [&] {
ET_SWITCH_REALHBBF16_TYPES(in.scalar_type(), ctx, name, CTYPE, [&] {
const CTYPE* in_data = in.const_data_ptr<CTYPE>();
CTYPE* out_data = out.mutable_data_ptr<CTYPE>();

Expand Down
30 changes: 19 additions & 11 deletions kernels/test/op_roll_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,26 @@ class OpRollOutTest : public ::testing::Test {
// first.
torch::executor::runtime_init();
}

template <ScalarType DTYPE>
void test_dtype() {
TensorFactory<DTYPE> tf;

Tensor input = tf.make({4, 2}, {1, 2, 3, 4, 5, 6, 7, 8});
int64_t shifts_data[2] = {2, 1};
ArrayRef<int64_t> shifts = ArrayRef<int64_t>(shifts_data, 2);
int64_t dims_data[2] = {0, 1};
ArrayRef<int64_t> dims = ArrayRef<int64_t>(dims_data, 2);
Tensor out = tf.zeros({4, 2});
Tensor out_expected = tf.make({4, 2}, {6, 5, 8, 7, 2, 1, 4, 3});
op_roll_out(input, shifts, dims, out);
EXPECT_TENSOR_CLOSE(out, out_expected);
}
};

TEST_F(OpRollOutTest, SmokeTest) {
TensorFactory<ScalarType::Float> tfFloat;

Tensor input = tfFloat.make({4, 2}, {1, 2, 3, 4, 5, 6, 7, 8});
int64_t shifts_data[2] = {2, 1};
ArrayRef<int64_t> shifts = ArrayRef<int64_t>(shifts_data, 2);
int64_t dims_data[2] = {0, 1};
ArrayRef<int64_t> dims = ArrayRef<int64_t>(dims_data, 2);
Tensor out = tfFloat.zeros({4, 2});
Tensor out_expected = tfFloat.make({4, 2}, {6, 5, 8, 7, 2, 1, 4, 3});
op_roll_out(input, shifts, dims, out);
EXPECT_TENSOR_CLOSE(out, out_expected);
#define TEST_ENTRY(ctype, dtype) test_dtype<ScalarType::dtype>();
// TODO: enable bool test after #7856 lands.
ET_FORALL_REALHBF16_TYPES(TEST_ENTRY);
#undef TEST_ENTRY
}
Loading