Skip to content

Support Half/BFloat16 in scatter #7864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

Support Half/BFloat16 in scatter #7864

merged 2 commits into from
Jan 23, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 23, 2025

Partial fix for #7748.

@swolchok
Update
5ef8339 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 23, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7864

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Pending

As of commit 3bc7d14 with merge base 26665f3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2025
swolchok added a commit that referenced this pull request Jan 23, 2025
@swolchok
Support Half/BFloat16 in scatter
17cbdd0 
Partial fix for #7748.

ghstack-source-id: c7be8eb
ghstack-comment-id: 2608589452
Pull Request resolved: #7864
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 23, 2025
@swolchok
Update
3bc7d14 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 23, 2025
@swolchok
Support Half/BFloat16 in scatter
14df69f 
Partial fix for #7748.

ghstack-source-id: 40b6cdd
ghstack-comment-id: 2608589452
Pull Request resolved: #7864
@swolchok
Copy link
Contributor Author

swolchok commented Jan 23, 2025

test failure is a known problem on main, landing

@swolchok swolchok merged commit 1947734 into main Jan 23, 2025
42 of 44 checks passed
@swolchok swolchok deleted the gh/swolchok/183/head branch January 23, 2025 18:47
@swolchok swolchok mentioned this pull request Jan 23, 2025
Closed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in scatter (#7864)
2bdd79f 
Partial fix for #7748.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in scatter (pytorch#7864)
c76e13e 
Partial fix for pytorch#7748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @manuelcandales @facebook-github-bot