Skip to content

Add clamp operator to Arm backend #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2025
Merged

Add clamp operator to Arm backend #7935

merged 3 commits into from
Jan 31, 2025

Conversation

@tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Jan 24, 2025 •
edited by pytorch-bot bot
Loading

  • Add support for aten.clamp
  • Amend QuantizeFullArgument pass to include quantization of clamp arguments

Signed-off-by: Tom Allsop tom.allsop@arm.com

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@tom-arm
Add clamp operator to Arm backend
df441f5 
* Add support for aten.clamp
* Amend QuantizeFullArgument pass to include quantization of clamp arguments

Signed-off-by: Tom Allsop <tom.allsop@arm.com>

Change-Id: I432f4ec60facc50fe45ca05c98308924d6e18109
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7935

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs, 1 Pending

As of commit ebffb7e with merge base 4796da7 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@tom-arm tom-arm added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Jan 24, 2025
@tom-arm
Copy link
Collaborator Author

tom-arm commented Jan 28, 2025

It looks like the failing jobs are unrelated to this change

@tom-arm
Address merge conflicts and typing issues
a39fbd5 
Signed-off-by: Tom Allsop <tom.allsop@arm.com>
Change-Id: If9f6bbb9d23f00b9cea6d00c6aa97a6d5d3e77ab
@tom-arm
Merge remote-tracking branch 'github/main' into add_clamp_operator
ebffb7e 
Change-Id: I134b18e6c7cdc63c0c1ebb98b7714f1cd9f2d02c
@zingo zingo merged commit 4a8fb17 into pytorch:main Jan 31, 2025
104 of 106 checks passed
@tom-arm tom-arm deleted the add_clamp_operator branch January 31, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tom-arm @zingo @facebook-github-bot