Add to.dtype and neg ops #8041

billmguo · 2025-01-29T19:41:45Z

Summary: add neg ops and annonation of to.dtype

Differential Revision: D68815927

pytorch-bot · 2025-01-29T19:41:50Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8041

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ROCM Infra failures during checkout of PyTorch

✅ No Failures

As of commit 511d3f3 with merge base e63c923 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-29T19:41:57Z

This pull request was exported from Phabricator. Differential Revision: D68815927

billmguo · 2025-01-29T19:43:08Z

@pytorchbot label "topic: not user facing"

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

facebook-github-bot · 2025-01-30T00:07:50Z

This pull request was exported from Phabricator. Differential Revision: D68815927

facebook-github-bot · 2025-01-30T06:04:26Z

This pull request was exported from Phabricator. Differential Revision: D68815927

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

facebook-github-bot · 2025-01-30T21:35:27Z

This pull request was exported from Phabricator. Differential Revision: D68815927

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

facebook-github-bot · 2025-01-30T23:53:45Z

This pull request was exported from Phabricator. Differential Revision: D68815927

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

facebook-github-bot · 2025-01-31T06:53:11Z

This pull request was exported from Phabricator. Differential Revision: D68815927

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

facebook-github-bot · 2025-01-31T07:10:27Z

This pull request was exported from Phabricator. Differential Revision: D68815927

facebook-github-bot · 2025-01-31T07:16:47Z

This pull request was exported from Phabricator. Differential Revision: D68815927

Summary: Pull Request resolved: pytorch#8041 pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

facebook-github-bot · 2025-01-31T21:48:47Z

This pull request was exported from Phabricator. Differential Revision: D68815927

Summary: Pull Request resolved: pytorch#8041 pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

billmguo · 2025-02-03T07:28:55Z

@shewu-quic would u mind review and approve I will remove to.dypte ops since I modify model it can eliminate the to.dtype

facebook-github-bot · 2025-02-03T07:46:04Z

This pull request was exported from Phabricator. Differential Revision: D68815927

Summary: Pull Request resolved: pytorch#8041 pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

facebook-github-bot · 2025-02-03T07:53:09Z

This pull request was exported from Phabricator. Differential Revision: D68815927

Summary: Pull Request resolved: pytorch#8041 pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

shewu-quic

@winskuo-quic, could you help to review this PR about CI

backends/qualcomm/builders/op_add.py

backends/qualcomm/tests/test_qnn_delegate.py

shewu-quic · 2025-02-03T08:04:24Z

backends/qualcomm/tests/utils.py

    image_dataset: str = ""
    pretrained_weight: str = ""
    enable_profile: bool = False
+    compile_only: bool = True


It seems to be duplicated

shewu-quic · 2025-02-03T08:05:01Z

backends/qualcomm/tests/utils.py

-    enable_x86_64: bool = False
+    enable_x86_64: bool = True
+    compile_only: bool = False
+    dump_intermediate_outputs: bool = False


May I know why do you need to add this variable?

this is chen's test code. I re-base on top her pr to run the unit test in x86 emulator

shewu-quic · 2025-02-03T08:05:19Z

backends/qualcomm/tests/utils.py

            )

            output_dir = f"{tmp_dir}/outputs"
+            os.makedirs(output_dir, exist_ok=True) 


make_output_dir(output_dir)

winskuo-quic · 2025-02-03T08:58:11Z

backends/qualcomm/tests/utils.py

    use_16a4w: str = "16a4w"
    shared_buffer: bool = False
-    enable_x86_64: bool = False
+    enable_x86_64: bool = True


May I know why we need to set enable_x86_64 to True?

winskuo-quic · 2025-02-03T08:59:11Z

backends/qualcomm/tests/models.py

        return self.pool(self.conv(x))


+class Conv2dArgmin(torch.nn.Module):


Conv2dArgmin should be in front of Conv2dAvgPool2d based on alphabetical order.

Summary: pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

facebook-github-bot · 2025-02-03T18:44:44Z

This pull request was exported from Phabricator. Differential Revision: D68815927

shewu-quic

LGTM. Thanks.

Summary: pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

facebook-github-bot · 2025-02-04T21:53:11Z

This pull request was exported from Phabricator. Differential Revision: D68815927

shewu-quic

LGTM. Thanks!

Summary: pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

facebook-github-bot · 2025-02-05T05:40:29Z

This pull request was exported from Phabricator. Differential Revision: D68815927

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2025

facebook-github-bot added the fb-exported label Jan 29, 2025

pytorch-bot bot added the topic: not user facing label Jan 29, 2025

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 30, 2025

Add to.dtype and neg ops

bd3c608

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

billmguo force-pushed the export-D68815927 branch from 200dd3d to bd3c608 Compare January 30, 2025 00:07

billmguo force-pushed the export-D68815927 branch from bd3c608 to a5874d9 Compare January 30, 2025 06:03

billmguo force-pushed the export-D68815927 branch from a5874d9 to f5e4d1d Compare January 30, 2025 21:34

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 30, 2025

Add to.dtype and neg ops (pytorch#8041)

f5e4d1d

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

billmguo force-pushed the export-D68815927 branch from f5e4d1d to 7111d80 Compare January 30, 2025 23:53

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 30, 2025

Add to.dtype and neg ops (pytorch#8041)

7111d80

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

billmguo force-pushed the export-D68815927 branch from 7111d80 to 041d496 Compare January 31, 2025 06:52

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 31, 2025

Add to.dtype and neg ops (pytorch#8041)

041d496

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 31, 2025

Add to.dtype and neg ops (pytorch#8041)

cb05bbb

Summary: pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

billmguo force-pushed the export-D68815927 branch from 041d496 to cb05bbb Compare January 31, 2025 07:09

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 31, 2025

Add to.dtype and neg ops (pytorch#8041)

30df6a3

Summary: Pull Request resolved: pytorch#8041 pytorch#8041 add neg ops and annonation of to.dtype Differential Revision: D68815927

billmguo force-pushed the export-D68815927 branch from cb05bbb to 30df6a3 Compare January 31, 2025 07:17

billmguo force-pushed the export-D68815927 branch from 30df6a3 to fb3179c Compare January 31, 2025 21:49

billmguo force-pushed the export-D68815927 branch from fb3179c to f101da0 Compare February 3, 2025 07:46

billmguo force-pushed the export-D68815927 branch from f101da0 to 19d7f42 Compare February 3, 2025 07:53

shewu-quic reviewed Feb 3, 2025

View reviewed changes

winskuo-quic reviewed Feb 3, 2025

View reviewed changes

billmguo added a commit to billmguo/executorch that referenced this pull request Feb 3, 2025

Add to.dtype and neg ops (pytorch#8041)

183fa36

Summary: pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

billmguo force-pushed the export-D68815927 branch from 19d7f42 to 183fa36 Compare February 3, 2025 18:43

shewu-quic approved these changes Feb 4, 2025

View reviewed changes

billmguo added a commit to billmguo/executorch that referenced this pull request Feb 4, 2025

Add to.dtype and neg ops (pytorch#8041)

b29759c

Summary: pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

billmguo force-pushed the export-D68815927 branch from 183fa36 to b29759c Compare February 4, 2025 21:52

shewu-quic approved these changes Feb 5, 2025

View reviewed changes

Add to.dtype and neg ops (pytorch#8041)

511d3f3

Summary: pytorch#8041 add neg ops and annonation of to.dtype Reviewed By: Andriyluck Differential Revision: D68815927

billmguo force-pushed the export-D68815927 branch from b29759c to 511d3f3 Compare February 5, 2025 05:40

limintang requested review from limintang February 5, 2025 17:18

limintang approved these changes Feb 5, 2025

View reviewed changes

facebook-github-bot merged commit 9832db9 into pytorch:main Feb 5, 2025
46 of 47 checks passed

		return self.pool(self.conv(x))


		class Conv2dArgmin(torch.nn.Module):

Add to.dtype and neg ops #8041

Add to.dtype and neg ops #8041

Uh oh!

Conversation

billmguo commented Jan 29, 2025

Uh oh!

pytorch-bot bot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8041

❗ 1 Active SEVs

✅ No Failures

Uh oh!

facebook-github-bot commented Jan 29, 2025

Uh oh!

billmguo commented Jan 29, 2025

Uh oh!

facebook-github-bot commented Jan 30, 2025

Uh oh!

facebook-github-bot commented Jan 30, 2025

Uh oh!

facebook-github-bot commented Jan 30, 2025

Uh oh!

facebook-github-bot commented Jan 30, 2025

Uh oh!

facebook-github-bot commented Jan 31, 2025

Uh oh!

facebook-github-bot commented Jan 31, 2025

Uh oh!

facebook-github-bot commented Jan 31, 2025

Uh oh!

facebook-github-bot commented Jan 31, 2025

Uh oh!

billmguo commented Feb 3, 2025

Uh oh!

facebook-github-bot commented Feb 3, 2025

Uh oh!

facebook-github-bot commented Feb 3, 2025

Uh oh!

shewu-quic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shewu-quic Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

shewu-quic Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

billmguo Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

shewu-quic Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

winskuo-quic Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

winskuo-quic Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 3, 2025

Uh oh!

shewu-quic left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 4, 2025

Uh oh!

shewu-quic left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

pytorch-bot bot commented Jan 29, 2025 •

edited

Loading