Add hardsigmoid operator to Arm backend #8091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add filter_fn to ops_to_not_decompose, to filter out quantized candidate ops * Added aten.hardsigmoid as a table op for the BI case Signed-off-by: Tom Allsop <tom.allsop@arm.com> Change-Id: I67e6d256dfae6ec6b8f679598043054d25d4a6de
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8091
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 2 Pending, 1 Unrelated FailureAs of commit 0ea3aed with merge base c9f5f19 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
tom-arm
added
partner: arm
zingo
approved these changes
Jan 31, 2025
|
macos job fail not related |
This is something we are trying to fix. But running into other issues. Sorry about that. |
digantdesai
reviewed
Jan 31, 2025
| self, | ||
| ep: ExportedProgram, | ||
| ) -> Tuple[List[torch._ops.OpOverload], Optional[Callable[[torch.fx.Node], bool]]]: | ||
| ops_to_not_decompose_if_quant_op = [ |
There was a problem hiding this comment.
Nit: why another list?
There was a problem hiding this comment.
This list is for ops where we specifically only want to not decompose if it's quantized. Also, another operator will be coming in a follow on commit, so a list is needed
There was a problem hiding this comment.
I see that you are using the same list in the filter_fn, sounds good, false alarm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Allsop tom.allsop@arm.com
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218