Arm backend mypy fixes #8092
Merged
Arm backend mypy fixes #8092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In arm_vela.py, function vela_compile() there is a reuse of the variable block_length that was of different type between uses and mypy complained. Change name of block_length that is used inside the loop to block_length_bytes since its not a int. Change-Id: If44e46269f777df903641f1cd4c30af4c60d5bbc
Fix mypy warnings in arm_model_evaluator.py Change-Id: Ife2e5502d5dacd71e92bd5a86fdf25a34b0fd2b6
Annotate a dict to fix mypy warning. Change-Id: Icbe9f846ecddcf974c47f355c36df63b9ea8f593
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8092
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 PendingAs of commit e7d4c09 with merge base ce93291 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
perheld
added
partner: arm
Collaborator
Author
|
Failing test (pull / unittest / macos / macos-job (pull_request)) doesn't seem related to me. |
zingo
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes for mypy warnings.
Test plan
Done with internal CI, no changes in result.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218