Make stage ids unique in the Arm TestPipeline #8338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some stages in the TestPipeline may be added multiple times, such as .check(). To be able to target these by id, give them an unique suffix -> 'id.suffix' Refering to stages in terms of id instead of an index is more self documenting and future proof. This change modifies the add/pop_stage interface: - pos arg in add_stage is now an optional kwarg, appending to the pipline as default - suffix is added to add_stage as an optional_kwarg. If a suffix is not given to a non unique stage, a number is added instead. - pop_stage now allows to use ids for referring to stages. Additionally adds .visualize(stage) for quickly adding visualizing stages to the pipeline. Change-Id: If649a19096ddee6b2eca2c8aa735b54ca7eea3e8
AdrianLundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8338
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 602b9c9 with merge base 5aa0ee2 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Feb 11, 2025
Collaborator
|
MacOs fails seems unrealted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stages in the TestPipeline may be added multiple times, such as .check(). To be able to target these by id, give them an unique suffix -> 'id.suffix' Refering to stages in terms of id instead of an index is more self documenting and future proof.
This change modifies the add/pop_stage interface:
Additionally adds .visualize(stage) for quickly adding visualizing stages to the pipeline.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218