Skip to content

Remove duplicated portable test targets #8389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Remove duplicated portable test targets #8389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions kernels/test/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
load("@fbsource//xplat/executorch/kernels/test:util.bzl", "codegen_function_header_wrapper", "generated_op_test", "op_test")
load("@fbsource//xplat/executorch/kernels/test:util.bzl", "codegen_function_header_wrapper", "op_test")

def _common_op_test(name, kernels):
"""
Expand All @@ -10,28 +10,6 @@ def _common_op_test(name, kernels):
deps = [":function_header_wrapper_{}".format(kernel)]
op_test(name, kernel_name = kernel, use_kernel_prefix = True, deps = deps)

def make_example_generated_op_test_target():
"""
Makes a test for kernels/test/util generated_op_test() helper
Here we use portable kernel. Try with `buck test xplat/executorch/kernels/test:op_<>_test`
"""
op_test_cpp_files = native.glob(
["op_*_test.cpp"],
# linear has no portable op.
exclude = ["op_linear_test.cpp"],
)

# The op name is from the beginning to the part without `_test.cpp` (:-9)
op_to_test = [f[:-9] for f in op_test_cpp_files]
for op_name in op_to_test:
generated_op_test(
op_name + "_test",
"//executorch/kernels/portable/cpu:{}".format(op_name),
"//executorch/kernels/portable:generated_lib_headers",
"//executorch/kernels/portable/test:supported_features",
"//executorch/kernels/test:function_header_wrapper_portable",
)

def define_common_targets():
"""Defines targets that should be shared between fbcode and xplat.

Expand Down Expand Up @@ -353,5 +331,3 @@ def define_common_targets():
_common_op_test("op_view_copy_test", ["aten", "portable"])
_common_op_test("op_where_test", ["aten", "portable"])
_common_op_test("op_zeros_test", ["aten", "portable"])

make_example_generated_op_test_target()
Loading