Fix TrainingModule Parameter Bug #8443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8443
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 4635a8d with merge base 0222074 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69568035 |
Summary: The params were being cloned and then cached so in python we observed them changing but the actual cpp weights being run against were not. Differential Revision: D69568035
JacobSzwejbka
force-pushed
the
export-D69568035
branch
from
8b43e2a to
4635a8d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69568035 |
jackzhxng
approved these changes
Feb 13, 2025
|
|
||
| self.named_grads = dict(zip(fqn, grads)) | ||
| if self.named_params is None: | ||
| params = full_outputs[params_start_idx:] |
Contributor
There was a problem hiding this comment.
nit: would be more clear if you added the comment about not cloning here instead imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The params were being cloned and then cached so in python we observed them changing but the actual cpp weights being run against were not.
Differential Revision: D69568035