Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Feb 13, 2025

Summary

OSSTestConfig.json is only used to generate cmake files. I generated the flat tensor cmake file using it, and then edited it to create the test pte files. Removing flat tensor from the config so that future cmake generation runs do not overwrite the file.

Test plan

ci

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8472

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 4aeba20 with merge base 0222074 (image):

NEW FAILURE - The following job has failed:

  • pull / unittest-arm / linux-job (gh)
    RuntimeError: Command docker exec -t 04cd16c50bd3afbb4d0acce8b6dbff1004a05c9b8eb846631a0084f9ddd5e5b7 /exec failed with exit code 1

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2025
@lucylq lucylq force-pushed the lfq.remove-flat-tensor-from-cmake-config branch from 24a39e7 to 4aeba20 Compare February 13, 2025 18:25
@lucylq lucylq marked this pull request as ready for review February 13, 2025 18:25
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit (I miss macros)

@lucylq lucylq merged commit caeb1ec into main Feb 13, 2025
44 of 47 checks passed
@lucylq lucylq deleted the lfq.remove-flat-tensor-from-cmake-config branch February 13, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants