patch qnn silu lowering #8494
Merged
patch qnn silu lowering #8494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8494
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3a97268 with merge base 7964bca ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69636086 |
cccclai
requested review from
chunit-quic,
haowhsu-quic,
shewu-quic and
winskuo-quic
| silu_node = src_partition.nodes[0] | ||
| with graph_module.graph.inserting_after(inputs[0]): | ||
| for node in graph.nodes: | ||
| if node.op == "call_function" and node.target in [ |
There was a problem hiding this comment.
Maybe we can use set here {.
There was a problem hiding this comment.
oh actually it's just one op and we can just compare...
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Feb 14, 2025
Summary: There are some edge lowering case missing. Change the logic to look for the op first because it's not decomposed Differential Revision: D69636086
cccclai
force-pushed
the
export-D69636086
branch
from
3c1a572 to
011cc87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69636086 |
winskuo-quic
approved these changes
Feb 14, 2025
Summary: There are some edge lowering case missing. Change the logic to look for the op first because it's not decomposed Reviewed By: billmguo Differential Revision: D69636086
cccclai
force-pushed
the
export-D69636086
branch
from
011cc87 to
3a97268
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69636086 |
kirklandsign
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There are some edge lowering case missing. Change the logic to look for the op first because it's not decomposed
Differential Revision: D69636086