Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Feb 17, 2025

Change asserts to exceptions, print more information on failure.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8515

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 34e009f with merge base a70c6a3 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2025
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 17, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2025
@zingo zingo changed the title Improve error handling in ArmBackend Arm: Improve error handling in ArmBackend Feb 17, 2025
Change asserts to exceptions,
Print more information on failure.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: If9fbf827458c2f8c35b998ea562d6047347ae10b
@zingo
Copy link
Collaborator

zingo commented Feb 18, 2025

MacOS fails unrelated

@zingo zingo merged commit 583d408 into pytorch:main Feb 18, 2025
108 of 109 checks passed
@Erik-Lundell Erik-Lundell deleted the improve-error branch July 31, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants