Arm: Support bitwise and, xor, and or ops #8518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ops are very similar and thus clumped together. No quantization since that doesn't make sense for bitwise ops. Add a factory for creating simple two input NodeVisitors. This can be extended for future such ops. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ic3615067cd03b8775f4b028f601b6b2366487c9d
Erik-Lundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8518
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit a90f1aa with merge base a70c6a3 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
MacOS fails unrelated |
zingo
approved these changes
Feb 18, 2025
digantdesai
reviewed
Feb 19, 2025
| # This source code is licensed under the BSD-style license found in the | ||
| # LICENSE file in the root directory of this source tree. | ||
|
|
||
| # pyre-unsafe |
There was a problem hiding this comment.
drop this in the future?
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 19, 2025
Summary: D69765254 (pytorch#8518) adds a file named `ops_binary.py` which doesn't match the current pattern of `op_*.py` files in this directory. Update the glob so that this new file will be picked up by the buck2 build, silencing a type-checking issue. Differential Revision: D69878804
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 19, 2025
Summary: D69765254 (pytorch#8518) adds a file named `ops_binary.py` which doesn't match the current pattern of `op_*.py` files in this directory. Update the glob so that this new file will be picked up by the buck2 build, silencing a type-checking issue. Differential Revision: D69878804
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 19, 2025
Summary: D69765254 (pytorch#8518) adds a file named `ops_binary.py` which doesn't match the current pattern of `op_*.py` files in this directory. Update the glob so that this new file will be picked up by the buck2 build, silencing a type-checking issue. Differential Revision: D69878804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ops are very similar and thus clumped together.
No quantization since that doesn't make sense for
bitwise ops.
Add a factory for creating simple two input NodeVisitors. This can be extended for future such ops.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218