Skip to content

Conversation

@tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Feb 18, 2025

  • Add ConvertToClampPass that converts relu and hardtanh to clamp
  • Remove op_relu and op_hardtanh visitors from backend

Signed-off-by: Tom Allsop tom.allsop@arm.com

Change-Id: Ieaf2d4ad97d407e3a01d9d09c6d7f954431e7869

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

* Add ConvertToClampPass that converts relu and hardtanh to clamp
* Remove op_relu and op_hardtanh visitors from backend

Signed-off-by: Tom Allsop <tom.allsop@arm.com>

Change-Id: Ieaf2d4ad97d407e3a01d9d09c6d7f954431e7869
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8538

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5884888 with merge base a01571f (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2025
@tom-arm tom-arm added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Feb 18, 2025
@swolchok swolchok requested a review from digantdesai February 18, 2025 18:37
@swolchok swolchok added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 18, 2025
@zingo
Copy link
Collaborator

zingo commented Feb 19, 2025

MacOS test fails are unrelated

@zingo zingo changed the title Add pass that converts operators to clamp to the Arm backend Arm: Add pass that converts operators to clamp to the Arm backend Feb 19, 2025
@zingo zingo merged commit 43efc37 into pytorch:main Feb 19, 2025
109 of 112 checks passed
@tom-arm tom-arm deleted the add_clamp_pass branch February 19, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants