Skip to content

Arm: Add aten.relu_.default to quantization_annotator #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

Arm: Add aten.relu_.default to quantization_annotator #8567

merged 1 commit into from
Feb 20, 2025

Conversation

@tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Feb 19, 2025 •
edited by pytorch-bot bot
Loading

  • The inplace version of relu (aten.relu_.default) was missing

Signed-off-by: Tom Allsop tom.allsop@arm.com

Change-Id: I08ae3fdc88b7fe569833a6111ab254ec8780fb14

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@tom-arm
Arm: Add aten.relu_.default to quantization_annotator
7a17aaa 
* The inplace version of relu (aten.relu_.default) was missing

Signed-off-by: Tom Allsop <tom.allsop@arm.com>

Change-Id: I08ae3fdc88b7fe569833a6111ab254ec8780fb14
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8567

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 7a17aaa with merge base 4f90ce4 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2025
@tom-arm tom-arm added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 19, 2025
@zingo zingo added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2025
@swolchok swolchok added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 19, 2025
@zingo
Copy link
Collaborator

zingo commented Feb 20, 2025

Fails unrelated

@zingo zingo merged commit 68eb62f into pytorch:main Feb 20, 2025
109 of 113 checks passed
@tom-arm tom-arm deleted the add_inplace_relu branch September 18, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@zingo zingo zingo approved these changes

@mcr229 mcr229 Awaiting requested review from mcr229

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tom-arm @zingo @digantdesai @swolchok @facebook-github-bot