Skip to content

Conversation

@dbort
Copy link
Contributor

@dbort dbort commented Feb 19, 2025

Summary: #8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Differential Revision: D69883148

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8588

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 51b7f58 with merge base 2b81e6f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

@dbort
Copy link
Contributor Author

dbort commented Feb 19, 2025

This export picked up the changes from #8585; I'll need to rebase on top of that once it lands (EDIT: done)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

dbort added a commit to dbort/executorch that referenced this pull request Feb 19, 2025
…ch#8588)

Summary:
Pull Request resolved: pytorch#8588

pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Reviewed By: swolchok

Differential Revision: D69883148
dbort added a commit to dbort/executorch that referenced this pull request Feb 20, 2025
…ch#8588)

Summary:
Pull Request resolved: pytorch#8588

pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Reviewed By: swolchok

Differential Revision: D69883148
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

dbort added a commit to dbort/executorch that referenced this pull request Feb 20, 2025
… fix type annotations (pytorch#8588)

Summary:
Pull Request resolved: pytorch#8588

pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Also fix some type annotations; the Meta-internal type checker seems to be more strict.

Reviewed By: swolchok

Differential Revision: D69883148
dbort added a commit to dbort/executorch that referenced this pull request Feb 21, 2025
… fix type annotations (pytorch#8588)

Summary:
Pull Request resolved: pytorch#8588

pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Also fix some type annotations; the Meta-internal type checker seems to be more strict.

Reviewed By: swolchok

Differential Revision: D69883148
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

dbort added a commit to dbort/executorch that referenced this pull request Feb 21, 2025
… fix type annotations (pytorch#8588)

Summary:
Pull Request resolved: pytorch#8588

pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Also fix some type annotations; the Meta-internal type checker seems to be more strict.

Reviewed By: swolchok

Differential Revision: D69883148
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

dbort added a commit to dbort/executorch that referenced this pull request Feb 21, 2025
… fix type annotations (pytorch#8588)

Summary:
Pull Request resolved: pytorch#8588

pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Also fix some type annotations; the Meta-internal type checker seems to be more strict.

Reviewed By: swolchok

Differential Revision: D69883148
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

dbort added a commit to dbort/executorch that referenced this pull request Feb 21, 2025
… fix type annotations (pytorch#8588)

Summary:
Pull Request resolved: pytorch#8588

pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Also fix some type annotations; the Meta-internal type checker seems to be more strict.

Reviewed By: swolchok

Differential Revision: D69883148
… fix type annotations (pytorch#8588)

Summary:
Pull Request resolved: pytorch#8588

pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies.

Also fix some type annotations; the Meta-internal type checker seems to be more strict.

Reviewed By: swolchok

Differential Revision: D69883148
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69883148

@facebook-github-bot facebook-github-bot merged commit f87940d into pytorch:main Feb 21, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants