Skip to content

Arm backend: Enable FVP tests for ops lowered to REDUCE_SUM #8617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

Arm backend: Enable FVP tests for ops lowered to REDUCE_SUM #8617

merged 2 commits into from
Feb 21, 2025

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Feb 21, 2025 •
edited by pytorch-bot bot
Loading

Summary

vela version is stepped to fix numerical issues with REDUCE_SUM.

cc @digantdesai @freddan80 @per @zingo

@oscarandersson8218
Enable FVP tests for ops lowered to REDUCE_SUM
566c702 
vela version is stepped to fix numerical issues with REDUCE_SUM.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I777512fb731c78c0fc97e251b6fb588ea6b3ff5a
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8617

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 1e95351 with merge base 282242e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 21, 2025
zingo
zingo requested changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@zingo zingo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAILED backends/arm/test/ops/test_bmm.py::TestBMM::test_bmm_single_input_u55_BI_xfails_0 - Failed: Unexpected success
'''
Interesting

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@oscarandersson8218
Add ExpectedFailureOnFvp for BMM U55 tests
1e95351 
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I4dad2943275fe7e09d77a0f05b23a4eee387a53e
@zingo
Copy link
Collaborator

zingo commented Feb 21, 2025

MacOS fails is unrelated

@zingo zingo merged commit cc922da into pytorch:main Feb 21, 2025
112 of 113 checks passed
digantdesai
digantdesai reviewed Feb 21, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai left review comments

@zingo zingo zingo approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oscarandersson8218 @zingo @digantdesai @facebook-github-bot