Fix issues with named data map load_into #8686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8686
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit bb2d0e9 with merge base 88b3441 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70186266 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Feb 25, 2025
Summary: Fix a couple bugs in load_into and add tests Differential Revision: D70186266
JacobSzwejbka
force-pushed
the
export-D70186266
branch
from
4f3b35b to
96acc28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70186266 |
lucylq
approved these changes
Feb 25, 2025
| } | ||
|
|
||
| ET_NODISCARD Result<size_t> FlatTensorDataMap::load_data_into( | ||
| ET_NODISCARD Error FlatTensorDataMap::load_data_into( |
Summary: Fix a couple bugs in load_into and add tests Reviewed By: lucylq Differential Revision: D70186266
JacobSzwejbka
force-pushed
the
export-D70186266
branch
from
96acc28 to
bb2d0e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70186266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix a couple bugs in load_into and add tests
Differential Revision: D70186266