Skip to content

Conversation

@swolchok
Copy link
Contributor

This is an option in the Buck shims that controls whether cxx_tests automatically depend on folly. ExecuTorch doesn't use folly.

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 10, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9088

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0b1f85e with merge base 1d34caf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok swolchok mentioned this pull request Mar 10, 2025
swolchok added a commit that referenced this pull request Mar 10, 2025
This is an option in the Buck shims that controls whether cxx_tests automatically depend on folly. ExecuTorch doesn't use folly.

ghstack-source-id: dd4cc59
ghstack-comment-id: 2711214717
Pull Request resolved: #9088
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2025
Base automatically changed from gh/swolchok/332/head to main March 10, 2025 22:29
@swolchok swolchok merged commit 68259f5 into main Mar 10, 2025
48 of 49 checks passed
@swolchok swolchok deleted the gh/swolchok/333/head branch March 10, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants