Arm backend: Add TOSA support for logical not #9128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I5bc8e68561e1403a2de388a3a0fd1f4435401ea9 Signed-off-by: Måns Nilsson <mans.nilsson@arm.com>
mansnils
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9128
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 1 Cancelled JobAs of commit eef03c7 with merge base e86c9c9 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
LGTM |
YufengShi-dudu
approved these changes
Mar 11, 2025
|
All the failures are unrelated to this commit. |
|
https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=-arm&mergeLF=true says this PR broke test-arm-reference-delegation and unittest-arm |
|
Hi @swolchok, thanks for pointing out the issue. After supporting the logical not op, the graph in test_conformer.py seems to have 8 "torch.ops.higher_order.executorch_call_delegate" now. We will double check this and create a patch to fix the failures. Thank you! |
YufengShi-dudu
added a commit
to YufengShi-dudu/executorch
that referenced
this pull request
Mar 13, 2025
1. Implement a pass ConvertAnyDefaultDimDimsPass to decompose any.default, any.dim and any.dims into a sequence of any.dim with keepdim=True and a squeeze_copy.dims if needed 2. Implement a NodeVisitor to lower any.dim to REDUCE_ANY in TOSA 3. Fix the failures in pytorch#9128 Change-Id: Ifb6672f2c017cd7365e76319795290a36909657c Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
per
pushed a commit
that referenced
this pull request
Mar 13, 2025
1. Implement a pass ConvertAnyDefaultDimDimsPass to decompose any.default, any.dim and any.dims into a sequence of any.dim with keepdim=True and a squeeze_copy.dims if needed 2. Implement a NodeVisitor to lower any.dim to REDUCE_ANY in TOSA 3. Fix the failures in #9128 Change-Id: Ifb6672f2c017cd7365e76319795290a36909657c Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TOSA support for logical not in Arm backend.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218